pinctrl: stm32: Add check for devm_kcalloc
authorChen Ni <nichen@iscas.ac.cn>
Tue, 31 Oct 2023 08:08:07 +0000 (08:08 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 13 Nov 2023 14:12:29 +0000 (15:12 +0100)
Add check for the return value of devm_kcalloc() and return the error
if it fails in order to avoid NULL pointer dereference.

Fixes: 32c170ff15b0 ("pinctrl: stm32: set default gpio line names using pin names")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Valentin Caron <valentin.caron@foss.st.com>
Link: https://lore.kernel.org/r/20231031080807.3600656-1-nichen@iscas.ac.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/stm32/pinctrl-stm32.c

index 64e8201c7eacd347ffa85c5139b937e0725016ec..3a9c458d3fc9820e0d322a18ebf0cf50821a32c9 100644 (file)
@@ -1368,6 +1368,11 @@ static int stm32_gpiolib_register_bank(struct stm32_pinctrl *pctl, struct fwnode
        }
 
        names = devm_kcalloc(dev, npins, sizeof(char *), GFP_KERNEL);
+       if (!names) {
+               err = -ENOMEM;
+               goto err_clk;
+       }
+
        for (i = 0; i < npins; i++) {
                stm32_pin = stm32_pctrl_get_desc_pin_from_gpio(pctl, bank, i);
                if (stm32_pin && stm32_pin->pin.name)