wifi: mt76: mt7915: drop always true condition of __mt7915_reg_addr()

smatch warnings:
addr <= MT_CBTOP2_PHY_END(0xffffffff) is always true (<= u32max),
so drop it.

Fixes: cd4c314a65d3 ("mt76: mt7915: refine register definition")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c b/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
index 0a95c3da241b5051ec413f42e8b1562f571b40b2..52be55dff947fbc6dd210333e6f405ea4877ec09 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
@@ -495,7 +495,7 @@ static u32 __mt7915_reg_addr(struct mt7915_dev *dev, u32 addr)
 
        if (dev_is_pci(dev->mt76.dev) &&
            ((addr >= MT_CBTOP1_PHY_START && addr <= MT_CBTOP1_PHY_END) ||
-            (addr >= MT_CBTOP2_PHY_START && addr <= MT_CBTOP2_PHY_END)))
+           addr >= MT_CBTOP2_PHY_START))
                return mt7915_reg_map_l1(dev, addr);
 
        /* CONN_INFRA: covert to phyiscal addr and use layer 1 remap */

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h
index aca1b2f1e9e3bc405ba8f40aee7ce828bd90a7ec..7e0d86366c778a6379e2d54661bf0e975dd7aac7 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h
@@ -803,7 +803,6 @@ enum offs_rev {
 #define MT_CBTOP1_PHY_START            0x70000000
 #define MT_CBTOP1_PHY_END              __REG(CBTOP1_PHY_END)
 #define MT_CBTOP2_PHY_START            0xf0000000
-#define MT_CBTOP2_PHY_END              0xffffffff
 #define MT_INFRA_MCU_START             0x7c000000
 #define MT_INFRA_MCU_END               __REG(INFRA_MCU_ADDR_END)
 #define MT_CONN_INFRA_OFFSET(p)                ((p) - MT_INFRA_BASE)