ALSA: pci: hda: hda_controller: Add support for use_pio_for_commands mode

Set the use_pio_for_commands flag in case AZX_DCAPS_PIO_COMMANDS quirk is
enabled.

When the PIO command mode is used we can re-use the existing
azx_single_send_cmd() / azx_single_get_response() functions safely as the
CORB DMA is not going to be enabled in snd_hdac_bus_init_cmd_io().

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Message-ID: <20240409083812.14001-4-peter.ujfalusi@linux.intel.com>

diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
index 206306a0eb827abaf0030a668959bba33f882fe5..8af5ee1b0ea8dd0e9e2a41e03a4ab1e166030197 100644 (file)
--- a/sound/pci/hda/hda_controller.c
+++ b/sound/pci/hda/hda_controller.c
@@ -914,7 +914,7 @@ static int azx_send_cmd(struct hdac_bus *bus, unsigned int val)
 
        if (chip->disabled)
                return 0;
-       if (chip->single_cmd)
+       if (chip->single_cmd || bus->use_pio_for_commands)
                return azx_single_send_cmd(bus, val);
        else
                return snd_hdac_bus_send_cmd(bus, val);
@@ -928,7 +928,7 @@ static int azx_get_response(struct hdac_bus *bus, unsigned int addr,
 
        if (chip->disabled)
                return 0;
-       if (chip->single_cmd)
+       if (chip->single_cmd || bus->use_pio_for_commands)
                return azx_single_get_response(bus, addr, res);
        else
                return azx_rirb_get_response(bus, addr, res);
@@ -1188,6 +1188,9 @@ int azx_bus_init(struct azx *chip, const char *model)
        if (chip->driver_caps & AZX_DCAPS_4K_BDLE_BOUNDARY)
                bus->core.align_bdle_4k = true;
 
+       if (chip->driver_caps & AZX_DCAPS_PIO_COMMANDS)
+               bus->core.use_pio_for_commands = true;
+
        /* enable sync_write flag for stable communication as default */
        bus->core.sync_write = 1;