media: rcar-isp: Disallow unbind of devices
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Wed, 31 Jan 2024 18:04:52 +0000 (19:04 +0100)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 7 Mar 2024 15:35:13 +0000 (16:35 +0100)
It is not safe to unbind and then rebind a subdevice in the rcar-vin
pipeline. Depending on what subdevice and in what order a device is
rebound the rcar-vin driver can misbehave.

Until this can be solved suppress the files in sysfs which allows for
this. This is in line with what is done for other subdevices exclusively
use with the rcar-vin pipeline, e.g. rcar-csi2.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/renesas/rcar-isp.c

index 530d65fc546bc63f3082b076729d98a841cf5d2f..4512ac338ca53be26298b08b9f254aff17cf0209 100644 (file)
@@ -518,6 +518,7 @@ static void risp_remove(struct platform_device *pdev)
 static struct platform_driver rcar_isp_driver = {
        .driver = {
                .name = "rcar-isp",
+               .suppress_bind_attrs = true,
                .of_match_table = risp_of_id_table,
        },
        .probe = risp_probe,