phy: rockchip-inno-usb2: remove redundant assignment to variable delay
authorColin Ian King <colin.i.king@gmail.com>
Sat, 11 Dec 2021 18:00:54 +0000 (18:00 +0000)
committerVinod Koul <vkoul@kernel.org>
Tue, 14 Dec 2021 09:15:07 +0000 (14:45 +0530)
Variable delay is being assigned to zero and the code falls through to
the next case in a switch statement that returns out of the function.
The variable is never read in this scenario and so the assignment is
redundant and can be removed.

Cleans up scan-build static analysis warning:
drivers/phy/rockchip/phy-rockchip-inno-usb2.c:753:3: warning: Value
stored to 'delay' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20211211180054.525368-1-colin.i.king@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c

index 1938365abbb375cfc875972f348ef36014b4be34..9f95b587e2c0d8bd09cbd50973043a160bfbefae 100644 (file)
@@ -750,7 +750,6 @@ static void rockchip_chg_detect_work(struct work_struct *work)
                fallthrough;
        case USB_CHG_STATE_SECONDARY_DONE:
                rphy->chg_state = USB_CHG_STATE_DETECTED;
-               delay = 0;
                fallthrough;
        case USB_CHG_STATE_DETECTED:
                /* put the controller in normal mode */