drm/amd/pm: return -ENOTSUPP if there is no get_dpm_ultimate_freq function
authorTom Rix <trix@redhat.com>
Mon, 24 Jan 2022 20:18:12 +0000 (12:18 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:26 +0000 (14:23 +0200)
[ Upstream commit 430e6a0212b2a0eb1de5e9d47a016fa79edf3978 ]

clang static analysis reports this represenative problem
amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value
        return clk_freq * 100;
               ~~~~~~~~ ^

If there is no get_dpm_ultimate_freq function,
smu_get_dpm_freq_range returns success without setting the
output min,max parameters.  So return an -ENOTSUPP error.

Fixes: e5ef784b1e17 ("drm/amd/powerplay: revise calling chain on retrieving frequency range")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c

index 6dc83cfad9d8450e5224e50aafeecdc30f3e58c7..8acdb244b99f7202acfcad7e79224d814587e4dc 100644 (file)
@@ -138,7 +138,7 @@ int smu_get_dpm_freq_range(struct smu_context *smu,
                           uint32_t *min,
                           uint32_t *max)
 {
-       int ret = 0;
+       int ret = -ENOTSUPP;
 
        if (!min && !max)
                return -EINVAL;