watchdog: asm9260_wdt: make array mode_name static, shrinks object size
authorColin Ian King <colin.king@canonical.com>
Thu, 29 Nov 2018 23:25:00 +0000 (23:25 +0000)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 22 Dec 2018 11:15:31 +0000 (12:15 +0100)
Don't populate the const array mode_name on the stack but instead
make it static. Makes the object code smaller by 41 bytes:

Before:
   text    data     bss     dec     hex filename
   7699    1872       0    9571    2563 drivers/watchdog/asm9260_wdt.o

After:
   text    data     bss     dec     hex filename
   7594    1936       0    9530    253a drivers/watchdog/asm9260_wdt.o

(gcc version 8.2.0 x86_64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/asm9260_wdt.c

index 2cf56b459d84c37411a9647d5fbf92927f5091a1..9768e44ffeb8a46d136e457bfc9e9e652540ee8d 100644 (file)
@@ -278,7 +278,7 @@ static int asm9260_wdt_probe(struct platform_device *pdev)
        struct watchdog_device *wdd;
        struct resource *res;
        int ret;
-       const char * const mode_name[] = { "hw", "sw", "debug", };
+       static const char * const mode_name[] = { "hw", "sw", "debug", };
 
        priv = devm_kzalloc(&pdev->dev, sizeof(struct asm9260_wdt_priv),
                            GFP_KERNEL);