staging: r8188eu: bHWPowerdown is set but not used
authorMartin Kaiser <martin@kaiser.cx>
Sun, 5 Dec 2021 15:12:45 +0000 (16:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Dec 2021 10:11:34 +0000 (11:11 +0100)
bHWPowerdown in struct pwrctrl_priv is set but never read. Remove it.

Acked-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20211205151251.6861-5-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
drivers/staging/r8188eu/include/rtw_pwrctrl.h

index acd343eec280bd961b8f352f4ee49913194540f0..d14c1757d7b3cf2f509be99e49a9871ec4626f30 100644 (file)
@@ -1118,22 +1118,16 @@ static void hal_get_chnl_group_88e(u8 chnl, u8 *group)
 void Hal_ReadPowerSavingMode88E(struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail)
 {
        if (AutoLoadFail) {
-               padapter->pwrctrlpriv.bHWPowerdown = false;
                padapter->pwrctrlpriv.bSupportRemoteWakeup = false;
        } else {
                /* hw power down mode selection , 0:rf-off / 1:power down */
 
-               if (padapter->registrypriv.hwpdn_mode == 2)
-                       padapter->pwrctrlpriv.bHWPowerdown = (hwinfo[EEPROM_RF_FEATURE_OPTION_88E] & BIT(4));
-               else
-                       padapter->pwrctrlpriv.bHWPowerdown = padapter->registrypriv.hwpdn_mode;
-
                /*  decide hw if support remote wakeup function */
                /*  if hw supported, 8051 (SIE) will generate WeakUP signal(D+/D- toggle) when autoresume */
                padapter->pwrctrlpriv.bSupportRemoteWakeup = (hwinfo[EEPROM_USB_OPTIONAL_FUNCTION0] & BIT(1)) ? true : false;
 
-               DBG_88E("%s...bHWPowerdown(%x) , bSupportRemoteWakeup(%x)\n", __func__,
-                       padapter->pwrctrlpriv.bHWPowerdown, padapter->pwrctrlpriv.bSupportRemoteWakeup);
+               DBG_88E("%s , bSupportRemoteWakeup(%x)\n", __func__,
+                       padapter->pwrctrlpriv.bSupportRemoteWakeup);
 
                DBG_88E("### PS params =>  power_mgnt(%x), usbss_enable(%x) ###\n", padapter->registrypriv.power_mgnt, padapter->registrypriv.usbss_enable);
        }
index b19ef796ab543b456c0262eeaea03c4d8e668054..a71f2f8f7c4301fc793a2e47d7687c48b3ed06ba 100644 (file)
@@ -93,7 +93,6 @@ struct pwrctrl_priv {
        enum rt_rf_power_state  change_rfpwrstate;
 
        u8              wepkeymask;
-       u8              bHWPowerdown;/* if support hw power down */
        u8              bkeepfwalive;
 };