iomap: Use bitmap ops to set uptodate bits
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Mon, 21 Sep 2020 15:58:40 +0000 (08:58 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Mon, 21 Sep 2020 15:59:26 +0000 (08:59 -0700)
Now that the bitmap is protected by a spinlock, we can use the
more efficient bitmap ops instead of individual test/set bit ops.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/iomap/buffered-io.c

index d1caea4c5fba53ec1fc3b26c88d02485760980a5..eab839b2be335de6af6d9a6d06ecd883eaec9dac 100644 (file)
@@ -134,19 +134,11 @@ iomap_iop_set_range_uptodate(struct page *page, unsigned off, unsigned len)
        struct inode *inode = page->mapping->host;
        unsigned first = off >> inode->i_blkbits;
        unsigned last = (off + len - 1) >> inode->i_blkbits;
-       bool uptodate = true;
        unsigned long flags;
-       unsigned int i;
 
        spin_lock_irqsave(&iop->uptodate_lock, flags);
-       for (i = 0; i < i_blocks_per_page(inode, page); i++) {
-               if (i >= first && i <= last)
-                       set_bit(i, iop->uptodate);
-               else if (!test_bit(i, iop->uptodate))
-                       uptodate = false;
-       }
-
-       if (uptodate)
+       bitmap_set(iop->uptodate, first, last - first + 1);
+       if (bitmap_full(iop->uptodate, i_blocks_per_page(inode, page)))
                SetPageUptodate(page);
        spin_unlock_irqrestore(&iop->uptodate_lock, flags);
 }