s390x/pci: use a reserved ID for the default PCI group
authorMatthew Rosato <mjrosato@linux.ibm.com>
Fri, 3 Dec 2021 14:27:03 +0000 (09:27 -0500)
committerThomas Huth <thuth@redhat.com>
Fri, 17 Dec 2021 08:12:37 +0000 (09:12 +0100)
The current default PCI group being used can technically collide with a
real group ID passed from a hostdev.  Let's instead use a group ID that
comes from a special pool (0xF0-0xFF) that is architected to be reserved
for simulated devices.

Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure")
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Message-Id: <20211203142706.427279-2-mjrosato@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
include/hw/s390x/s390-pci-bus.h

index aa891c178dded24f1611dd05c401d285ccdebdb6..2727e7bdefbeec4504b9e225588d8c9d2fbe5a73 100644 (file)
@@ -313,7 +313,7 @@ typedef struct ZpciFmb {
 } ZpciFmb;
 QEMU_BUILD_BUG_MSG(offsetof(ZpciFmb, fmt0) != 48, "padding in ZpciFmb");
 
-#define ZPCI_DEFAULT_FN_GRP 0x20
+#define ZPCI_DEFAULT_FN_GRP 0xFF
 typedef struct S390PCIGroup {
     ClpRspQueryPciGrp zpci_group;
     int id;