libdecnumber/dpd/decimal64: Fix compiler warning from Clang 15
authorThomas Huth <thuth@redhat.com>
Thu, 10 Nov 2022 13:11:12 +0000 (14:11 +0100)
committerThomas Huth <thuth@redhat.com>
Fri, 11 Nov 2022 08:13:52 +0000 (09:13 +0100)
Clang 15 from Fedora 37 complains:

 ../libdecnumber/dpd/decimal64.c:620:8: error: variable 'n' set but
 not used [-Werror,-Wunused-but-set-variable]
   Int  n;                     /* output bunch counter */
        ^
 1 error generated.

Remove the unused variable to silence the compiler warning.

Message-Id: <20221110131112.104283-1-thuth@redhat.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
libdecnumber/dpd/decimal64.c

index 4816176410f963ff026903dbf8ec66665f33cf24..290dbe8177174239a4657769a0b07a74250d9bdd 100644 (file)
@@ -617,7 +617,6 @@ static const uInt multies[]={131073, 26215, 5243, 1049, 210};
 #endif
 void decDigitsToDPD(const decNumber *dn, uInt *targ, Int shift) {
   Int  cut;                  /* work */
-  Int  n;                    /* output bunch counter */
   Int  digits=dn->digits;     /* digit countdown */
   uInt dpd;                  /* densely packed decimal value */
   uInt bin;                  /* binary value 0-999 */
@@ -676,7 +675,7 @@ void decDigitsToDPD(const decNumber *dn, uInt *targ, Int shift) {
     bin=0;                        /* [keep compiler quiet] */
   #endif
 
-  for(n=0; digits>0; n++) {       /* each output bunch */
+  while (digits > 0) {             /* each output bunch */
     #if DECDPUN==3                /* fast path, 3-at-a-time */
       bin=*inu;                           /* 3 digits ready for convert */
       digits-=3;                  /* [may go negative] */