mlx4: handle non-napi callers to napi_poll
authorJonathan Lemon <bsd@fb.com>
Thu, 8 Oct 2020 18:45:26 +0000 (11:45 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 12 Oct 2020 21:02:32 +0000 (14:02 -0700)
netcons calls napi_poll with a budget of 0 to transmit packets.
Handle this by:
 - skipping RX processing
 - do not try to recycle TX packets to the RX cache

Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx4/en_rx.c
drivers/net/ethernet/mellanox/mlx4/en_tx.c

index b50c567ef508e71276938049f9dc31dd7cceeac3..24006440e86e2010eb9f1c8196e92487100b532e 100644 (file)
@@ -943,6 +943,9 @@ int mlx4_en_poll_rx_cq(struct napi_struct *napi, int budget)
        bool clean_complete = true;
        int done;
 
+       if (!budget)
+               return 0;
+
        if (priv->tx_ring_num[TX_XDP]) {
                xdp_tx_cq = priv->tx_cq[TX_XDP][cq->ring];
                if (xdp_tx_cq->xdp_busy) {
index 9dff7b086c9fb06ca889f618228b82e3d8b08762..1f11379ad5b6483f7212970b3f359e2595d82d97 100644 (file)
@@ -350,7 +350,7 @@ u32 mlx4_en_recycle_tx_desc(struct mlx4_en_priv *priv,
                .dma = tx_info->map0_dma,
        };
 
-       if (!mlx4_en_rx_recycle(ring->recycle_ring, &frame)) {
+       if (!napi_mode || !mlx4_en_rx_recycle(ring->recycle_ring, &frame)) {
                dma_unmap_page(priv->ddev, tx_info->map0_dma,
                               PAGE_SIZE, priv->dma_dir);
                put_page(tx_info->page);