ata: libahci_platform: fix IRQ check
authorSergey Shtylyov <s.shtylyov@omprussia.ru>
Mon, 15 Mar 2021 20:15:06 +0000 (23:15 +0300)
committerJens Axboe <axboe@kernel.dk>
Wed, 31 Mar 2021 02:24:20 +0000 (20:24 -0600)
Iff platform_get_irq() returns 0, ahci_platform_init_host() would return 0
early (as if the call was successful). Override IRQ0 with -EINVAL instead
as the 'libata' regards 0 as "no IRQ" (thus polling) anyway...

Fixes: c034640a32f8 ("ata: libahci: properly propagate return value of platform_get_irq()")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Link: https://lore.kernel.org/r/4448c8cc-331f-2915-0e17-38ea34e251c8@omprussia.ru
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/ata/libahci_platform.c

index de638dafce21e38a96c48923b5f3fc0ee93425fb..b2f55208829187d5234b505e1bdc28c8c0c5fdd8 100644 (file)
@@ -582,11 +582,13 @@ int ahci_platform_init_host(struct platform_device *pdev,
        int i, irq, n_ports, rc;
 
        irq = platform_get_irq(pdev, 0);
-       if (irq <= 0) {
+       if (irq < 0) {
                if (irq != -EPROBE_DEFER)
                        dev_err(dev, "no irq\n");
                return irq;
        }
+       if (!irq)
+               return -EINVAL;
 
        hpriv->irq = irq;