platform/x86/fujitsu-laptop: Replace sprintf() with sysfs_emit()

As suggested by Documentation/filesystems/sysfs.rst sysfs_emit() should be
used when formatting the value to be returned to user space.

Signed-off-by: Szilard Fabian <szfabian@bluemarch.art>
Link: https://lore.kernel.org/r/20240428192548.113261-1-szfabian@bluemarch.art
Acked-by: Jonathan Woithe <jwoithe@just42.net>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
index 94480af4946783e60e4ee1940950df2d0dc0132e..968fc91bd5e4057cfb5c9fa0757c6c06c97b392e 100644 (file)
--- a/drivers/platform/x86/fujitsu-laptop.c
+++ b/drivers/platform/x86/fujitsu-laptop.c
@@ -386,11 +386,11 @@ static ssize_t lid_show(struct device *dev, struct device_attribute *attr,
        struct fujitsu_laptop *priv = dev_get_drvdata(dev);
 
        if (!(priv->flags_supported & FLAG_LID))
-               return sprintf(buf, "unknown\n");
+               return sysfs_emit(buf, "unknown\n");
        if (priv->flags_state & FLAG_LID)
-               return sprintf(buf, "open\n");
+               return sysfs_emit(buf, "open\n");
        else
-               return sprintf(buf, "closed\n");
+               return sysfs_emit(buf, "closed\n");
 }
 
 static ssize_t dock_show(struct device *dev, struct device_attribute *attr,
@@ -399,11 +399,11 @@ static ssize_t dock_show(struct device *dev, struct device_attribute *attr,
        struct fujitsu_laptop *priv = dev_get_drvdata(dev);
 
        if (!(priv->flags_supported & FLAG_DOCK))
-               return sprintf(buf, "unknown\n");
+               return sysfs_emit(buf, "unknown\n");
        if (priv->flags_state & FLAG_DOCK)
-               return sprintf(buf, "docked\n");
+               return sysfs_emit(buf, "docked\n");
        else
-               return sprintf(buf, "undocked\n");
+               return sysfs_emit(buf, "undocked\n");
 }
 
 static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
@@ -412,11 +412,11 @@ static ssize_t radios_show(struct device *dev, struct device_attribute *attr,
        struct fujitsu_laptop *priv = dev_get_drvdata(dev);
 
        if (!(priv->flags_supported & FLAG_RFKILL))
-               return sprintf(buf, "unknown\n");
+               return sysfs_emit(buf, "unknown\n");
        if (priv->flags_state & FLAG_RFKILL)
-               return sprintf(buf, "on\n");
+               return sysfs_emit(buf, "on\n");
        else
-               return sprintf(buf, "killed\n");
+               return sysfs_emit(buf, "killed\n");
 }
 
 static DEVICE_ATTR_RO(lid);