ASoC: SOF: using pm_runtime_resume_and_get to simplify the code
authorMinghao Chi <chi.minghao@zte.com.cn>
Wed, 20 Apr 2022 03:03:15 +0000 (03:03 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 20 Apr 2022 20:18:20 +0000 (21:18 +0100)
Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
pm_runtime_put_noidle. This change is just to simplify the code, no
actual functional changes.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220420030315.2575691-1-chi.minghao@zte.com.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/sof-client-probes.c

index 797dedb26163c6ba821f507549901183bd9cba8d..c4c6e03c813317ed1426692278664bd53d6eb0af 100644 (file)
@@ -503,10 +503,9 @@ static ssize_t sof_probes_dfs_points_read(struct file *file, char __user *to,
        if (!buf)
                return -ENOMEM;
 
-       ret = pm_runtime_get_sync(dev);
+       ret = pm_runtime_resume_and_get(dev);
        if (ret < 0 && ret != -EACCES) {
                dev_err_ratelimited(dev, "debugfs read failed to resume %d\n", ret);
-               pm_runtime_put_noidle(dev);
                goto exit;
        }
 
@@ -568,10 +567,9 @@ sof_probes_dfs_points_write(struct file *file, const char __user *from,
 
        desc = (struct sof_probe_point_desc *)tkns;
 
-       ret = pm_runtime_get_sync(dev);
+       ret = pm_runtime_resume_and_get(dev);
        if (ret < 0 && ret != -EACCES) {
                dev_err_ratelimited(dev, "debugfs write failed to resume %d\n", ret);
-               pm_runtime_put_noidle(dev);
                goto exit;
        }
 
@@ -621,10 +619,9 @@ sof_probes_dfs_points_remove_write(struct file *file, const char __user *from,
                goto exit;
        }
 
-       ret = pm_runtime_get_sync(dev);
+       ret = pm_runtime_resume_and_get(dev);
        if (ret < 0) {
                dev_err_ratelimited(dev, "debugfs write failed to resume %d\n", ret);
-               pm_runtime_put_noidle(dev);
                goto exit;
        }