drm/i915/gem: Replace user_access_begin by user_write_access_begin
authorChristophe Leroy <christophe.leroy@c-s.fr>
Fri, 3 Apr 2020 07:20:52 +0000 (07:20 +0000)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 1 May 2020 02:35:22 +0000 (12:35 +1000)
When i915_gem_execbuffer2_ioctl() is using user_access_begin(),
that's only to perform unsafe_put_user() so use
user_write_access_begin() in order to only open write access.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/ebf1250b6d4f351469fb339e5399d8b92aa8a1c1.1585898438.git.christophe.leroy@c-s.fr
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c

index b7440f06c5e24e9303b0b6e2cddb997a098d3089..8a4e9c1cbf6c1262d9e68e85760b899e502d46bf 100644 (file)
@@ -2794,7 +2794,8 @@ i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data,
                 * And this range already got effectively checked earlier
                 * when we did the "copy_from_user()" above.
                 */
-               if (!user_access_begin(user_exec_list, count * sizeof(*user_exec_list)))
+               if (!user_write_access_begin(user_exec_list,
+                                            count * sizeof(*user_exec_list)))
                        goto end;
 
                for (i = 0; i < args->buffer_count; i++) {
@@ -2808,7 +2809,7 @@ i915_gem_execbuffer2_ioctl(struct drm_device *dev, void *data,
                                        end_user);
                }
 end_user:
-               user_access_end();
+               user_write_access_end();
 end:;
        }