media: i2c: dw9714: Return zero in remove callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 31 Mar 2022 13:31:32 +0000 (14:31 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 24 Apr 2022 07:26:45 +0000 (08:26 +0100)
The only effect of returning an error code in an i2c remove callback is
that the i2c core emits a generic warning and still removes the device.

So even if disabling the regulator fails it's sensible to further cleanup
and then return zero to only emit a single error message.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/dw9714.c

index 8c5797ba57d418b7f858b4cd74a495a75624114f..206d74338b9c9d2ab236da6ef138b1507e8b675a 100644 (file)
@@ -202,7 +202,6 @@ static int dw9714_remove(struct i2c_client *client)
                if (ret) {
                        dev_err(&client->dev,
                                "Failed to disable vcc: %d\n", ret);
-                       return ret;
                }
        }
        pm_runtime_set_suspended(&client->dev);