net: pcs: altera-tse: don't set the speed for 1000BaseX
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Fri, 25 Nov 2022 13:18:00 +0000 (14:18 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 30 Nov 2022 04:29:55 +0000 (20:29 -0800)
When disabling the SGMII mode bit, the PCS defaults to 1000BaseX mode.
In that mode, we don't need to set the speed since it's always 1000Mbps.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pcs/pcs-altera-tse.c

index e86cadc391e80069ded8c02ea4c54beb7f78e72f..be65271ff5de9a385af11ac2829cdf4bd998df2d 100644 (file)
@@ -102,7 +102,6 @@ static int alt_tse_pcs_config(struct phylink_pcs *pcs, unsigned int mode,
                if_mode |= PCS_IF_MODE_USE_SGMII_AN | PCS_IF_MODE_SGMII_ENA;
        } else if (interface == PHY_INTERFACE_MODE_1000BASEX) {
                if_mode &= ~(PCS_IF_MODE_USE_SGMII_AN | PCS_IF_MODE_SGMII_ENA);
-               if_mode |= PCS_IF_MODE_SGMI_SPEED_1000;
        }
 
        ctrl |= (BMCR_SPEED1000 | BMCR_FULLDPLX | BMCR_ANENABLE);