mlxsw: spectrum_fid: Drop unnecessary conditions
authorPetr Machata <petrm@nvidia.com>
Mon, 20 Nov 2023 18:25:28 +0000 (19:25 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 21 Nov 2023 22:53:09 +0000 (14:53 -0800)
The caller already only calls mlxsw_sp_fid_flood_tables_init() and
mlxsw_sp_fid_flood_tables_fini() if (fid_family->flood_tables). There
is no configuration where the pointer is non-NULL, but the number of
tables is zero. So drop the conditions.

Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/897c6841bc756ac632b797bf67ac83c6a66ba359.1700503644.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c

index 6a509913bdc7228efc360a7a7d567877d4d73d64..d7fc579f3b29beb0f86816c43a293a4ff5e3e946 100644 (file)
@@ -1692,9 +1692,6 @@ mlxsw_sp_fid_flood_tables_init(struct mlxsw_sp_fid_family *fid_family)
        int err;
        int i;
 
-       if (!fid_family->nr_flood_tables)
-               return 0;
-
        pgt_size = mlxsw_sp_fid_family_pgt_size(fid_family);
        err = mlxsw_sp_pgt_mid_alloc_range(mlxsw_sp, &fid_family->pgt_base,
                                           pgt_size);
@@ -1723,9 +1720,6 @@ mlxsw_sp_fid_flood_tables_fini(struct mlxsw_sp_fid_family *fid_family)
        struct mlxsw_sp *mlxsw_sp = fid_family->mlxsw_sp;
        u16 pgt_size;
 
-       if (!fid_family->nr_flood_tables)
-               return;
-
        pgt_size = mlxsw_sp_fid_family_pgt_size(fid_family);
        mlxsw_sp_pgt_mid_free_range(mlxsw_sp, fid_family->pgt_base, pgt_size);
 }