clk: visconti: Fix memory leak in visconti_register_pll()
authorXiu Jianfeng <xiujianfeng@huawei.com>
Tue, 22 Nov 2022 15:23:53 +0000 (23:23 +0800)
committerStephen Boyd <sboyd@kernel.org>
Tue, 29 Nov 2022 20:11:00 +0000 (12:11 -0800)
@pll->rate_table has allocated memory by kmemdup(), if clk_hw_register()
fails, it should be freed, otherwise it will cause memory leak issue,
this patch fixes it.

Fixes: b4cbe606dc36 ("clk: visconti: Add support common clock driver and reset driver")
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221122152353.204132-1-xiujianfeng@huawei.com
Acked-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/visconti/pll.c

index a484cb945d67bacd6cf418143b81914020b74ad8..1f3234f22667446557a2e8d36843378a2841ac73 100644 (file)
@@ -277,6 +277,7 @@ static struct clk_hw *visconti_register_pll(struct visconti_pll_provider *ctx,
        ret = clk_hw_register(NULL, &pll->hw);
        if (ret) {
                pr_err("failed to register pll clock %s : %d\n", name, ret);
+               kfree(pll->rate_table);
                kfree(pll);
                pll_hw_clk = ERR_PTR(ret);
        }