i2c: hix5hd2: use 'time_left' variable with wait_for_completion_timeout()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 27 Apr 2024 20:35:56 +0000 (22:35 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:50 +0000 (00:56 +0200)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-hix5hd2.c

index 8e75515c3ca4784cf94d3245b0fdb1c2fd81401e..a47b9939fa2ce2cb7d5fb99746e65c7da75895fe 100644 (file)
@@ -314,7 +314,7 @@ static void hix5hd2_i2c_message_start(struct hix5hd2_i2c_priv *priv, int stop)
 static int hix5hd2_i2c_xfer_msg(struct hix5hd2_i2c_priv *priv,
                                struct i2c_msg *msgs, int stop)
 {
-       unsigned long timeout;
+       unsigned long time_left;
        int ret;
 
        priv->msg = msgs;
@@ -327,9 +327,9 @@ static int hix5hd2_i2c_xfer_msg(struct hix5hd2_i2c_priv *priv,
        reinit_completion(&priv->msg_complete);
        hix5hd2_i2c_message_start(priv, stop);
 
-       timeout = wait_for_completion_timeout(&priv->msg_complete,
-                                             priv->adap.timeout);
-       if (timeout == 0) {
+       time_left = wait_for_completion_timeout(&priv->msg_complete,
+                                               priv->adap.timeout);
+       if (time_left == 0) {
                priv->state = HIX5I2C_STAT_RW_ERR;
                priv->err = -ETIMEDOUT;
                dev_warn(priv->dev, "%s timeout=%d\n",