sheepdog: fix snapshot tag initialization
authorLiu Yuan <namei.unix@gmail.com>
Fri, 7 Jun 2013 17:54:25 +0000 (01:54 +0800)
committerKevin Wolf <kwolf@redhat.com>
Mon, 17 Jun 2013 15:47:58 +0000 (17:47 +0200)
This is an old and obvious bug. We should pass snapshot_id to the
tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail

Cc: qemu-devel@nongnu.org
Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Liu Yuan <namei.unix@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/sheepdog.c

index 21a4edf15befe3e673273c5814ccb21748455352..94218ac937fcd7785f11cfb3e61b2efe77f26b23 100644 (file)
@@ -2063,7 +2063,7 @@ static int sd_snapshot_goto(BlockDriverState *bs, const char *snapshot_id)
     if (snapid) {
         tag[0] = 0;
     } else {
-        pstrcpy(tag, sizeof(tag), s->name);
+        pstrcpy(tag, sizeof(tag), snapshot_id);
     }
 
     ret = reload_inode(s, snapid, tag);