Staging: rtl8188eu: Fix a constant comparison coding style issue
authorPriti Chattopadhyay <pritias81@gmail.com>
Thu, 23 Jul 2020 09:21:55 +0000 (14:51 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jul 2020 18:34:34 +0000 (20:34 +0200)
Modify equality comparison involving constants by shifting the constant
operand to the right side of the comparison as suggested by
scripts/checkpatch.pl

Signed-off-by: Priti Chattopadhyay <pritias81@gmail.com>
Link: https://lore.kernel.org/r/20200723092150.y34bentngeeci2oc@pritichattopadhyay
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_wlan_util.c

index 6df873e4c2ed7d1b706979f5b2908f725b1d091b..be843fd2461a317935964738638a9ba34ab5c62b 100644 (file)
@@ -967,7 +967,7 @@ int rtw_check_bcn_info(struct adapter  *Adapter, u8 *pframe, u32 packet_len)
                pbuf = rtw_get_wpa_ie(&bssid->ies[12], &wpa_ielen,
                                      bssid->ie_length - 12);
                if (pbuf && (wpa_ielen > 0)) {
-                       if (_SUCCESS == rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher, &pairwise_cipher, &is_8021x)) {
+                       if (rtw_parse_wpa_ie(pbuf, wpa_ielen + 2, &group_cipher, &pairwise_cipher, &is_8021x) == _SUCCESS) {
                                RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_,
                                         ("%s pnetwork->pairwise_cipher: %d, group_cipher is %d, is_8021x is %d\n", __func__,
                                         pairwise_cipher, group_cipher, is_8021x));
@@ -977,7 +977,7 @@ int rtw_check_bcn_info(struct adapter  *Adapter, u8 *pframe, u32 packet_len)
                                               bssid->ie_length - 12);
 
                        if (pbuf && (wpa_ielen > 0)) {
-                               if (_SUCCESS == rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, &group_cipher, &pairwise_cipher, &is_8021x)) {
+                               if (rtw_parse_wpa2_ie(pbuf, wpa_ielen + 2, &group_cipher, &pairwise_cipher, &is_8021x) == _SUCCESS) {
                                        RT_TRACE(_module_rtl871x_mlme_c_, _drv_info_,
                                                 ("%s pnetwork->pairwise_cipher: %d, pnetwork->group_cipher is %d, is_802x is %d\n",
                                                  __func__, pairwise_cipher, group_cipher, is_8021x));