tests: gpio-mockup: don't allocate the chip structure twice

We incorrectly allocate the chip structure twice: once in
gpio_mockup_probe() and then again in make_chip() which leads to a
memory leak. Remove the first instance as it's the one that's
unnecessary.

Fixes: e43e46d4f79c ("tests: mockup: add a library for controlling the gpio-mockup module")
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

diff --git a/tests/mockup/gpio-mockup.c b/tests/mockup/gpio-mockup.c
index 2af3c3115c8f50bf0b542f7242ae6a1aef04af17..358fec639fe1ebf46ced60d3d95c1b06b95c2784 100644 (file)
--- a/tests/mockup/gpio-mockup.c
+++ b/tests/mockup/gpio-mockup.c
@@ -304,12 +304,6 @@ EXPORT int gpio_mockup_probe(struct gpio_mockup *ctx, unsigned int num_chips,
        if (!ctx->chips)
                goto err_remove_module;
 
-       for (i = 0; i < num_chips; i++) {
-               ctx->chips[i] = malloc(sizeof(struct gpio_mockup_chip));
-               if (!ctx->chips[i])
-                       goto err_free_chips;
-       }
-
        pfd.fd = udev_monitor_get_fd(monitor);
        pfd.events = POLLIN | POLLPRI;