__ocfs2_add_entry(), ocfs2_prepare_dir_for_insert(): namelen checks
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 12 Nov 2023 22:03:14 +0000 (17:03 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 21 Dec 2023 17:53:21 +0000 (12:53 -0500)
namelen can't be zero; neither when it's coming from dentry name,
nor when dealing with orphans (in ocfs2_orphan_add() and
__ocfs2_prepare_orphan_dir()).  Rudiment of old ext2 pointless
check, long gone in ext2 itself...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/ocfs2/dir.c

index a14c8fee6ee5ea9d40d1d7494ef41e8cf1de4b2e..d620d4c53c6fadacbe518d0e277160509b46a464 100644 (file)
@@ -1593,9 +1593,6 @@ int __ocfs2_add_entry(handle_t *handle,
        struct buffer_head *insert_bh = lookup->dl_leaf_bh;
        char *data_start = insert_bh->b_data;
 
-       if (!namelen)
-               return -EINVAL;
-
        if (ocfs2_dir_indexed(dir)) {
                struct buffer_head *bh;
 
@@ -4245,12 +4242,6 @@ int ocfs2_prepare_dir_for_insert(struct ocfs2_super *osb,
        trace_ocfs2_prepare_dir_for_insert(
                (unsigned long long)OCFS2_I(dir)->ip_blkno, namelen);
 
-       if (!namelen) {
-               ret = -EINVAL;
-               mlog_errno(ret);
-               goto out;
-       }
-
        /*
         * Do this up front to reduce confusion.
         *