wifi: mt76: mt7915: workaround dubious x | !y warning
authorKalle Valo <kvalo@kernel.org>
Mon, 25 Mar 2024 15:58:38 +0000 (17:58 +0200)
committerKalle Valo <kvalo@kernel.org>
Thu, 28 Mar 2024 13:08:26 +0000 (15:08 +0200)
Sparse warns:

drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c:526:9: warning: dubious: x | !y

Workaround it by using the '?' operator. Compile tested only.

Signed-off-by: Kalle Valo <kvalo@kernel.org>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240325155838.1558680-1-kvalo@kernel.org
drivers/net/wireless/mediatek/mt76/mt7915/debugfs.c

index 450f4d221184b03427eb2847ba5b33e56abe7fc3..578013884e4381fe5f729eedd97e3136f56cec1a 100644 (file)
@@ -523,7 +523,8 @@ mt7915_fw_debug_wm_set(void *data, u64 val)
 
        /* WM CPU info record control */
        mt76_clear(dev, MT_CPU_UTIL_CTRL, BIT(0));
-       mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) | !dev->fw.debug_wm);
+       mt76_wr(dev, MT_DIC_CMD_REG_CMD, BIT(2) | BIT(13) |
+               (dev->fw.debug_wm ? 0 : BIT(0)));
        mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_MASK_CLR_ADDR, BIT(5));
        mt76_wr(dev, MT_MCU_WM_CIRQ_IRQ_SOFT_ADDR, BIT(5));