staging: r8188eu: core: remove goto statement

Remove the goto statement from rtw_do_join(). In this function goto
can be replace by return statement. As on goto label exit, function only
return it is not performing any cleanup. Avoiding goto will improve
the function readability.

Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
Link: https://lore.kernel.org/r/YXafzp5F8T7/+tk2@Sauravs-MacBook-Air.local
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/core/rtw_ioctl_set.c b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
index 2b54cdfa9d6ead65609c6b9a17b71d3eb8b094ba..411b06e135bedead8d39900a26c220f79192c651 100644 (file)
--- a/drivers/staging/r8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/r8188eu/core/rtw_ioctl_set.c
@@ -51,7 +51,7 @@ u8 rtw_do_join(struct adapter *padapter)
                        ret = _FAIL;
                }
 
-               goto exit;
+               return ret;
        } else {
                int select_ret;
 
@@ -78,10 +78,9 @@ u8 rtw_do_join(struct adapter *padapter)
 
                                rtw_generate_random_ibss(pibss);
 
-                               if (rtw_createbss_cmd(padapter) != _SUCCESS) {
-                                       ret =  false;
-                                       goto exit;
-                               }
+                               if (rtw_createbss_cmd(padapter) != _SUCCESS)
+                                       return false;
+
                                pmlmepriv->to_join = false;
                        } else {
                                /*  can't associate ; reset under-linking */
@@ -102,8 +101,6 @@ u8 rtw_do_join(struct adapter *padapter)
                }
        }
 
-exit:
-
        return ret;
 }