selftests: mptcp: removed defined but unused vars
authorMatthieu Baerts <matthieu.baerts@tessares.net>
Wed, 30 Nov 2022 14:06:24 +0000 (15:06 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 2 Dec 2022 04:06:05 +0000 (20:06 -0800)
Some variables were set but never used.

This was not causing any issues except adding some confusion and having
shellcheck complaining about them.

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/mptcp_connect.sh
tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
tools/testing/selftests/net/mptcp/simult_flows.sh

index 60198b91a530eb22aec5d90796cee8f3d07f2c5e..63b722b505e589ec217ad57e5cbfb1a8dcf2d2b5 100755 (executable)
@@ -781,7 +781,6 @@ run_tests_mptfo()
 
 run_tests_disconnect()
 {
-       local peekmode="$1"
        local old_cin=$cin
        local old_sin=$sin
 
@@ -789,7 +788,6 @@ run_tests_disconnect()
 
        # force do_transfer to cope with the multiple tranmissions
        sin="$cin.disconnect"
-       sin_disconnect=$old_sin
        cin="$cin.disconnect"
        cin_disconnect="$old_cin"
        connect_per_transfer=3
@@ -800,7 +798,6 @@ run_tests_disconnect()
 
        # restore previous status
        sin=$old_sin
-       sin_disconnect="$cout".disconnect
        cin=$old_cin
        cin_disconnect="$cin".disconnect
        connect_per_transfer=1
index 8a83100b212e937a2895c98a5292c7b1bf79929c..6e8f4599cc44e2ce24888e50c25b1d2cafbf8f7f 100755 (executable)
@@ -10,7 +10,6 @@ ksft_skip=4
 timeout_poll=30
 timeout_test=$((timeout_poll * 2 + 1))
 mptcp_connect=""
-do_all_tests=1
 
 add_mark_rules()
 {
index a5aeefd58ab3b7fa731c8542ef1cf605df273106..189a664aed81cc0cc383da63d73aa80e81b979af 100755 (executable)
@@ -148,9 +148,6 @@ do_transfer()
        :> "$sout"
        :> "$capout"
 
-       local addr_port
-       addr_port=$(printf "%s:%d" ${connect_addr} ${port})
-
        if $capture; then
                local capuser
                if [ -z $SUDO_USER ] ; then