clk: keystone: sci-clk: check return value of kasprintf()
authorClaudiu Beznea <claudiu.beznea@microchip.com>
Tue, 30 May 2023 09:39:11 +0000 (12:39 +0300)
committerStephen Boyd <sboyd@kernel.org>
Sat, 17 Jun 2023 04:52:50 +0000 (21:52 -0700)
kasprintf() returns a pointer to dynamically allocated memory.
Pointer could be NULL in case allocation fails. Check pointer validity.
Identified with coccinelle (kmerr.cocci script).

Fixes: b745c0794e2f ("clk: keystone: Add sci-clk driver support")
Depends-on: 96488c09b0f4 ("clk: keystone: sci-clk: cut down the clock name length")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20230530093913.1656095-7-claudiu.beznea@microchip.com
Reviewed-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/keystone/sci-clk.c

index 910ecd58c4ca2e7eae7496adf81faca55e97600a..6c1df4f11536dd0a6571625ec0028ce0ff77cbd0 100644 (file)
@@ -294,6 +294,8 @@ static int _sci_clk_build(struct sci_clk_provider *provider,
 
        name = kasprintf(GFP_KERNEL, "clk:%d:%d", sci_clk->dev_id,
                         sci_clk->clk_id);
+       if (!name)
+               return -ENOMEM;
 
        init.name = name;