i2c: img-scb: remove printout on handled timeouts
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Wed, 10 Apr 2024 11:24:21 +0000 (13:24 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:33 +0000 (00:56 +0200)
I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout and
simplify the logic a little.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-img-scb.c

index f9d4bfef511c3067dd0359b42152719f6c353f0f..e0e87185f6bbfc7abb18d681a414b73fac0b4a92 100644 (file)
@@ -1124,11 +1124,8 @@ static int img_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs,
                                                      IMG_I2C_TIMEOUT);
                del_timer_sync(&i2c->check_timer);
 
-               if (time_left == 0) {
-                       dev_err(adap->dev.parent, "i2c transfer timed out\n");
+               if (time_left == 0)
                        i2c->msg_status = -ETIMEDOUT;
-                       break;
-               }
 
                if (i2c->msg_status)
                        break;