i2c: i801: remove printout on handled timeouts
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 23 Apr 2024 12:13:18 +0000 (14:13 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Sun, 5 May 2024 22:56:47 +0000 (00:56 +0200)
I2C and SMBus timeouts are not something the user needs to be informed
about on controller level. The client driver may know if that really is
a problem and give more detailed information to the user. The controller
should just pass this information upwards. Remove the printout and turn
the SMBus-specific termination message to debug.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-i801.c

index e577abc776c1e4fbcae48ac09a190a6e347e48a3..d2d2a6dbe29f22d706e369ff84efef6a6663df33 100644 (file)
@@ -399,9 +399,7 @@ static int i801_check_post(struct i801_priv *priv, int status)
         * If the SMBus is still busy, we give up
         */
        if (unlikely(status < 0)) {
-               dev_err(&priv->pci_dev->dev, "Transaction timeout\n");
                /* try to stop the current command */
-               dev_dbg(&priv->pci_dev->dev, "Terminating the current operation\n");
                outb_p(SMBHSTCNT_KILL, SMBHSTCNT(priv));
                usleep_range(1000, 2000);
                outb_p(0, SMBHSTCNT(priv));
@@ -410,7 +408,7 @@ static int i801_check_post(struct i801_priv *priv, int status)
                status = inb_p(SMBHSTSTS(priv));
                if ((status & SMBHSTSTS_HOST_BUSY) ||
                    !(status & SMBHSTSTS_FAILED))
-                       dev_err(&priv->pci_dev->dev,
+                       dev_dbg(&priv->pci_dev->dev,
                                "Failed terminating the transaction\n");
                return -ETIMEDOUT;
        }