vt82c686: Simplify by returning earlier

By returning earlier we can remove the 'can_write' boolean variable.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <15b2968fd300a12d06b42368d084f6f80d3c3be5.1610223397.git.balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[PMD: Split original patch in 5, this is part 3/5]
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 2f69b4d531f488847efb16c4c892c23122009523..2bd10d91013358565176c40d4169544dd0423954 100644 (file)
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -258,7 +258,6 @@ static void superio_cfg_write(void *opaque, hwaddr addr, uint64_t data,
 {
     SuperIOConfig *sc = opaque;
     uint8_t idx = sc->regs[0];
-    bool can_write = true;
 
     if (addr == 0x3f0) { /* config index register */
         idx = data & 0xff;
@@ -276,15 +275,13 @@ static void superio_cfg_write(void *opaque, hwaddr addr, uint64_t data,
     case 0xf7:
     case 0xf9 ... 0xfb:
     case 0xfd ... 0xff:
-        can_write = false;
-        break;
+        /* ignore write to read only registers */
+        return;
     /* case 0xe6 ... 0xe8: Should set base port of parallel and serial */
     default:
         break;
     }
-    if (can_write) {
-        sc->regs[idx] = data & 0xff;
-    }
+    sc->regs[idx] = data & 0xff;
 }
 
 static uint64_t superio_cfg_read(void *opaque, hwaddr addr, unsigned size)