vhost-user-gpu: fix memory leak while calling 'vg_resource_unref' (CVE-2021-3544)
authorLi Qiang <liq3ea@163.com>
Sun, 16 May 2021 03:03:59 +0000 (20:03 -0700)
committerGerd Hoffmann <kraxel@redhat.com>
Thu, 27 May 2021 09:55:59 +0000 (11:55 +0200)
If the guest trigger following sequences, the attach_backing will be leaked:

vg_resource_create_2d
vg_resource_attach_backing
vg_resource_unref

This patch fix this by freeing 'res->iov' in vg_resource_destroy.

Fixes: CVE-2021-3544
Reported-by: Li Qiang <liq3ea@163.com>
virtio-gpu fix: 5e8e3c4c75 ("virtio-gpu: fix resource leak
in virgl_cmd_resource_unref")

Reviewed-by: Prasad J Pandit <pjp@fedoraproject.org>
Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20210516030403.107723-5-liq3ea@163.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
contrib/vhost-user-gpu/vhost-user-gpu.c

index 0437e52b64604512607e548d01d8717a3ef5228d..770dfad52989b2651eea67fdbb1b8cec6794b354 100644 (file)
@@ -400,6 +400,7 @@ vg_resource_destroy(VuGpu *g,
     }
 
     vugbm_buffer_destroy(&res->buffer);
+    g_free(res->iov);
     pixman_image_unref(res->image);
     QTAILQ_REMOVE(&g->reslist, res, next);
     g_free(res);