crypto: shash - Allow cloning on algorithms with no init_tfm

Some shash algorithms are so simple that they don't have an init_tfm
function.  These can be cloned trivially.  Check this before failing
in crypto_clone_shash.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/crypto/shash.c b/crypto/shash.c
index 717b42df3495ed55a87e744da3153e898a380cf2..1fadb6b59bdcc1afdd61b280813249327b4025d5 100644 (file)
--- a/crypto/shash.c
+++ b/crypto/shash.c
@@ -597,7 +597,7 @@ struct crypto_shash *crypto_clone_shash(struct crypto_shash *hash)
                return hash;
        }
 
-       if (!alg->clone_tfm)
+       if (!alg->clone_tfm && (alg->init_tfm || alg->base.cra_init))
                return ERR_PTR(-ENOSYS);
 
        nhash = crypto_clone_tfm(&crypto_shash_type, tfm);
@@ -606,10 +606,12 @@ struct crypto_shash *crypto_clone_shash(struct crypto_shash *hash)
 
        nhash->descsize = hash->descsize;
 
-       err = alg->clone_tfm(nhash, hash);
-       if (err) {
-               crypto_free_shash(nhash);
-               return ERR_PTR(err);
+       if (alg->clone_tfm) {
+               err = alg->clone_tfm(nhash, hash);
+               if (err) {
+                       crypto_free_shash(nhash);
+                       return ERR_PTR(err);
+               }
        }
 
        return nhash;