rtc: max31335: use regmap_update_bits_check

Simplify the IRQ handler by using regmap_update_bits_check.

Reviewed-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Link: https://lore.kernel.org/r/20240115232215.273374-2-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c
index 2ce23f60a7f34419bc228727e6ff65cc6cbee750..a38d303d9df4d8bb619eb5f7a0fa409e39b2cd00 100644 (file)
--- a/drivers/rtc/rtc-max31335.c
+++ b/drivers/rtc/rtc-max31335.c
@@ -348,18 +348,16 @@ static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled)
 static irqreturn_t max31335_handle_irq(int irq, void *dev_id)
 {
        struct max31335_data *max31335 = dev_id;
-       int ret, status;
+       bool status;
+       int ret;
 
-       ret = regmap_read(max31335->regmap, MAX31335_STATUS1, &status);
+       ret = regmap_update_bits_check(max31335->regmap, MAX31335_STATUS1,
+                                      MAX31335_STATUS1_A1F, 0, &status);
        if (ret)
                return IRQ_HANDLED;
 
-       if (FIELD_GET(MAX31335_STATUS1_A1F, status)) {
-               regmap_update_bits(max31335->regmap, MAX31335_STATUS1,
-                                  MAX31335_STATUS1_A1F, 0);
-
+       if (status)
                rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF);
-       }
 
        return IRQ_HANDLED;
 }