rtc: rx8111: demote warnings to debug level
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 17 Apr 2024 19:19:35 +0000 (21:19 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 7 May 2024 21:40:10 +0000 (23:40 +0200)
The proper way for userspace to react on a read time error is to have a
look at the voltage low information. There is no point in cluttering dmesg
as it is often not even visible to the end user.

Reviewed-by: Waqar Hameed <waqar.hameed@axis.com>
Link: https://lore.kernel.org/r/20240417191937.33790-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-rx8111.c

index 62d2352de10294c44c31278f6958dceb615c895a..4a35bd921b3346cd9a5fbc3f8f6ea61dd4e4e13f 100644 (file)
@@ -170,14 +170,14 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
        }
 
        if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) {
-               dev_warn(data->dev,
-                        "Crystal oscillation stopped, time is not reliable\n");
+               dev_dbg(data->dev,
+                       "Crystal oscillation stopped, time is not reliable\n");
                return -EINVAL;
        }
 
        if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) {
-               dev_warn(data->dev,
-                        "Low voltage detected, time is not reliable\n");
+               dev_dbg(data->dev,
+                       "Low voltage detected, time is not reliable\n");
                return -EINVAL;
        }
 
@@ -188,7 +188,7 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm)
        }
 
        if (regval) {
-               dev_warn(data->dev, "Clock stopped, time is not reliable\n");
+               dev_dbg(data->dev, "Clock stopped, time is not reliable\n");
                return -EINVAL;
        }