gpio: nomadik: fix Kconfig dependencies inbetween pinctrl & GPIO
authorThéo Lebrun <theo.lebrun@bootlin.com>
Fri, 1 Mar 2024 10:39:26 +0000 (11:39 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 1 Mar 2024 13:30:28 +0000 (14:30 +0100)
PINCTRL_NOMADIK cannot select GPIO_NOMADIK without first selecting
GPIOLIB on which GPIO_NOMADIK depends. GPIO_NOMADIK depends on OF_GPIO,
it is a direct dependency.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403010917.pnDhdS1Y-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202403011102.v8w2zPOU-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202403011329.1VnABMRz-lkp@intel.com/
Closes: https://lore.kernel.org/oe-kbuild-all/202403011546.Hpt8sBTa-lkp@intel.com/
Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Link: https://lore.kernel.org/r/20240301-mbly-gpio-kconfig-fix-v1-1-2785cebd475d@bootlin.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/Kconfig
drivers/pinctrl/nomadik/Kconfig

index fe6112abb73a3bf63843d0c4a7c8e0c08b72bfa3..f633be517654a14aad2558865f89f44556ba110c 100644 (file)
@@ -481,7 +481,7 @@ config GPIO_MXS
 config GPIO_NOMADIK
        bool "Nomadik GPIO driver"
        depends on ARCH_U8500 || ARCH_NOMADIK || MACH_EYEQ5 || COMPILE_TEST
-       select OF_GPIO
+       depends on OF_GPIO
        select GPIOLIB_IRQCHIP
        help
          Say yes here to support the Nomadik SoC GPIO block. This block is also
index 59d0d885651c7c96d936a6df733fde9d9666e490..aafecf3486704179611edcc37cad84982b462d01 100644 (file)
@@ -25,6 +25,7 @@ config PINCTRL_NOMADIK
        depends on OF
        select PINMUX
        select PINCONF
+       select GPIOLIB
        select GPIO_NOMADIK
 
 config PINCTRL_STN8815