pinctrl: samsung: Remove EINT handler for Exynos850 ALIVE and CMGP gpios
authorSam Protsenko <semen.protsenko@linaro.org>
Fri, 14 Jan 2022 20:37:57 +0000 (22:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:12 +0000 (14:23 +0200)
[ Upstream commit 96f79935015cf3d7ca6fabf63cd13b8af45a7713 ]

GPIO_ALIVE and GPIO_CMGP blocks in Exynos850 SoC don't have EINT
capabilities (like EINT_SVC register), and there are no corresponding
interrupts wired to GIC. Instead those blocks have wake-up interrupts
for each pin. The ".eint_gpio_init" callbacks were specified by mistake
for these blocks, when porting pinctrl code from downstream kernel. That
leads to error messages like this:

    samsung-pinctrl 11850000.pinctrl: irq number not available

Remove ".eint_gpio_init" for pinctrl_alive and pinctrl_gpmc to fix this
error. This change doesn't affect proper interrupt handling for related
pins, as all those pins are handled in ".eint_wkup_init".

Fixes: cdd3d945dcec ("pinctrl: samsung: Add Exynos850 SoC specific data")
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Link: https://lore.kernel.org/r/20220114203757.4860-1-semen.protsenko@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pinctrl/samsung/pinctrl-exynos-arm64.c

index fe5f6046fbd52349ec8098ed47abb7d784ccb813..cc66f852ef7bc8f86180479e3204afdceb53aa2c 100644 (file)
@@ -504,13 +504,11 @@ static const struct samsung_pin_ctrl exynos850_pin_ctrl[] __initconst = {
                /* pin-controller instance 0 ALIVE data */
                .pin_banks      = exynos850_pin_banks0,
                .nr_banks       = ARRAY_SIZE(exynos850_pin_banks0),
-               .eint_gpio_init = exynos_eint_gpio_init,
                .eint_wkup_init = exynos_eint_wkup_init,
        }, {
                /* pin-controller instance 1 CMGP data */
                .pin_banks      = exynos850_pin_banks1,
                .nr_banks       = ARRAY_SIZE(exynos850_pin_banks1),
-               .eint_gpio_init = exynos_eint_gpio_init,
                .eint_wkup_init = exynos_eint_wkup_init,
        }, {
                /* pin-controller instance 2 AUD data */