platform/x86/amd: pmc: Don't try to read SMU version on Picasso
authorMario Limonciello <mario.limonciello@amd.com>
Sun, 9 Apr 2023 18:53:41 +0000 (00:23 +0530)
committerHans de Goede <hdegoede@redhat.com>
Tue, 11 Apr 2023 08:37:16 +0000 (10:37 +0200)
Picasso doesn't support the command in the uPEP mailbox to try to
read the SMU version.

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2449
Fixes: f6045de1f532 ("platform/x86: amd-pmc: Export Idlemask values based on the APU")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230409185348.556161-2-Shyam-sundar.S-k@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd/pmc.c

index 2761e9b76e9578082e56ca476c9229c4c79a9d9d..2758c0e63a1cf702339a4063eca79b89a5f84634 100644 (file)
@@ -403,6 +403,9 @@ static int amd_pmc_get_smu_version(struct amd_pmc_dev *dev)
        int rc;
        u32 val;
 
+       if (dev->cpu_id == AMD_CPU_ID_PCO)
+               return -ENODEV;
+
        rc = amd_pmc_send_cmd(dev, 0, &val, SMU_MSG_GETSMUVERSION, 1);
        if (rc)
                return rc;