iommu: Fix return code in iommu_group_alloc_default_domain()
authorJason Gunthorpe <jgg@nvidia.com>
Wed, 4 Oct 2023 12:08:32 +0000 (09:08 -0300)
committerJoerg Roedel <jroedel@suse.de>
Thu, 5 Oct 2023 11:03:40 +0000 (13:03 +0200)
This function returns NULL on errors, not ERR_PTR.

Fixes: 1c68cbc64fe6 ("iommu: Add IOMMU_DOMAIN_PLATFORM")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/8fb75157-6c81-4a9c-9992-d73d49902fa8@moroto.mountain
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/0-v2-ee2bae9af0f2+96-iommu_ga_err_ptr_jgg@nvidia.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/iommu.c

index 21d45e6a5931a137efe54ad56066e6a5502c60f5..f9f315d58a3a1498ee03e1fe24d15741e43903e6 100644 (file)
@@ -1787,7 +1787,7 @@ iommu_group_alloc_default_domain(struct iommu_group *group, int req_type)
         */
        if (ops->default_domain) {
                if (req_type)
-                       return ERR_PTR(-EINVAL);
+                       return NULL;
                return ops->default_domain;
        }