powerpc/pseries/hibernation: remove redundant cacheinfo update
authorNathan Lynch <nathanl@linux.ibm.com>
Mon, 7 Dec 2020 21:51:56 +0000 (15:51 -0600)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 8 Dec 2020 10:41:02 +0000 (21:41 +1100)
Partitions with cache nodes in the device tree can encounter the
following warning on resume:

CPU 0 already accounted in PowerPC,POWER9@0(Data)
WARNING: CPU: 0 PID: 3177 at arch/powerpc/kernel/cacheinfo.c:197 cacheinfo_cpu_online+0x640/0x820

These calls to cacheinfo_cpu_offline/online have been redundant since
commit e610a466d16a ("powerpc/pseries/mobility: rebuild cacheinfo
hierarchy post-migration").

Fixes: e610a466d16a ("powerpc/pseries/mobility: rebuild cacheinfo hierarchy post-migration")
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20201207215200.1785968-25-nathanl@linux.ibm.com
arch/powerpc/platforms/pseries/suspend.c

index 703728cb95ec133fa9f5db5446269f922742dd1a..6a94cc0deb8838a3ab3ed07d419bd22a5ab09579 100644 (file)
@@ -13,7 +13,6 @@
 #include <asm/mmu.h>
 #include <asm/rtas.h>
 #include <asm/topology.h>
-#include "../../kernel/cacheinfo.h"
 
 static struct device suspend_dev;
 static DECLARE_COMPLETION(suspend_work);
@@ -63,9 +62,7 @@ static void pseries_suspend_enable_irqs(void)
         * Update configuration which can be modified based on device tree
         * changes during resume.
         */
-       cacheinfo_cpu_offline(smp_processor_id());
        post_mobility_fixup();
-       cacheinfo_cpu_online(smp_processor_id());
 }
 
 /**