efi/libstub: Move get_dram_base() into arm-stub.c
authorArd Biesheuvel <ardb@kernel.org>
Mon, 10 Feb 2020 16:02:42 +0000 (17:02 +0100)
committerArd Biesheuvel <ardb@kernel.org>
Sun, 23 Feb 2020 20:57:15 +0000 (21:57 +0100)
get_dram_base() is only called from arm-stub.c so move it into
the same source file as its caller.

Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
drivers/firmware/efi/libstub/arm-stub.c
drivers/firmware/efi/libstub/efi-stub-helper.c
drivers/firmware/efi/libstub/efistub.h

index 39ce4c459ea7b3154916ec9935cddf3466bb7344..1e0ff23ef3c305c329339ff3c540b9a921402d70 100644 (file)
@@ -88,6 +88,39 @@ void install_memreserve_table(void)
                pr_efi_err("Failed to install memreserve config table!\n");
 }
 
+static unsigned long get_dram_base(void)
+{
+       efi_status_t status;
+       unsigned long map_size, buff_size;
+       unsigned long membase  = EFI_ERROR;
+       struct efi_memory_map map;
+       efi_memory_desc_t *md;
+       struct efi_boot_memmap boot_map;
+
+       boot_map.map            = (efi_memory_desc_t **)&map.map;
+       boot_map.map_size       = &map_size;
+       boot_map.desc_size      = &map.desc_size;
+       boot_map.desc_ver       = NULL;
+       boot_map.key_ptr        = NULL;
+       boot_map.buff_size      = &buff_size;
+
+       status = efi_get_memory_map(&boot_map);
+       if (status != EFI_SUCCESS)
+               return membase;
+
+       map.map_end = map.map + map_size;
+
+       for_each_efi_memory_desc_in_map(&map, md) {
+               if (md->attribute & EFI_MEMORY_WB) {
+                       if (membase > md->phys_addr)
+                               membase = md->phys_addr;
+               }
+       }
+
+       efi_bs_call(free_pool, map.map);
+
+       return membase;
+}
 
 /*
  * This function handles the architcture specific differences between arm and
index 92ccd0a51ae69a879e80aebc8594ebadaa2e2583..1a8f2cf5a2bd6f3b20a071e9215a3cf291c869ce 100644 (file)
@@ -75,41 +75,6 @@ void efi_printk(char *str)
        }
 }
 
-
-unsigned long get_dram_base(void)
-{
-       efi_status_t status;
-       unsigned long map_size, buff_size;
-       unsigned long membase  = EFI_ERROR;
-       struct efi_memory_map map;
-       efi_memory_desc_t *md;
-       struct efi_boot_memmap boot_map;
-
-       boot_map.map =          (efi_memory_desc_t **)&map.map;
-       boot_map.map_size =     &map_size;
-       boot_map.desc_size =    &map.desc_size;
-       boot_map.desc_ver =     NULL;
-       boot_map.key_ptr =      NULL;
-       boot_map.buff_size =    &buff_size;
-
-       status = efi_get_memory_map(&boot_map);
-       if (status != EFI_SUCCESS)
-               return membase;
-
-       map.map_end = map.map + map_size;
-
-       for_each_efi_memory_desc_in_map(&map, md) {
-               if (md->attribute & EFI_MEMORY_WB) {
-                       if (membase > md->phys_addr)
-                               membase = md->phys_addr;
-               }
-       }
-
-       efi_bs_call(free_pool, map.map);
-
-       return membase;
-}
-
 static efi_status_t efi_file_size(void *__fh, efi_char16_t *filename_16,
                                  void **handle, u64 *file_sz)
 {
index b94c63d17a4f2dce57f6ed0124ed68e647961687..5123def761e97671ebe96334b80ded463666fc42 100644 (file)
@@ -549,8 +549,6 @@ efi_status_t efi_exit_boot_services(void *handle,
 
 void efi_char16_printk(efi_char16_t *);
 
-unsigned long get_dram_base(void);
-
 efi_status_t allocate_new_fdt_and_exit_boot(void *handle,
                                            unsigned long *new_fdt_addr,
                                            unsigned long max_addr,