i2c: stm32f7: indicate the address being accessed on errors
authorAlain Volmat <alain.volmat@foss.st.com>
Fri, 5 Feb 2021 08:51:44 +0000 (09:51 +0100)
committerWolfram Sang <wsa@kernel.org>
Thu, 18 Mar 2021 10:58:33 +0000 (11:58 +0100)
To help debugging issues, add the address of the slave being
accessed when getting an error.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Pierre-Yves MORDRET <pierre-yves.mordret@foss.st.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-stm32f7.c

index c019548e9dedc920ce45d489ff7bd13c360e602f..162a3b069261f95e79dd7e0fb78c68a2254a812d 100644 (file)
@@ -1602,7 +1602,8 @@ static irqreturn_t stm32f7_i2c_isr_error(int irq, void *data)
 
        /* Bus error */
        if (status & STM32F7_I2C_ISR_BERR) {
-               dev_err(dev, "<%s>: Bus error\n", __func__);
+               dev_err(dev, "<%s>: Bus error accessing addr 0x%x\n",
+                       __func__, f7_msg->addr);
                writel_relaxed(STM32F7_I2C_ICR_BERRCF, base + STM32F7_I2C_ICR);
                stm32f7_i2c_release_bus(&i2c_dev->adap);
                f7_msg->result = -EIO;
@@ -1610,13 +1611,15 @@ static irqreturn_t stm32f7_i2c_isr_error(int irq, void *data)
 
        /* Arbitration loss */
        if (status & STM32F7_I2C_ISR_ARLO) {
-               dev_dbg(dev, "<%s>: Arbitration loss\n", __func__);
+               dev_dbg(dev, "<%s>: Arbitration loss accessing addr 0x%x\n",
+                       __func__, f7_msg->addr);
                writel_relaxed(STM32F7_I2C_ICR_ARLOCF, base + STM32F7_I2C_ICR);
                f7_msg->result = -EAGAIN;
        }
 
        if (status & STM32F7_I2C_ISR_PECERR) {
-               dev_err(dev, "<%s>: PEC error in reception\n", __func__);
+               dev_err(dev, "<%s>: PEC error in reception accessing addr 0x%x\n",
+                       __func__, f7_msg->addr);
                writel_relaxed(STM32F7_I2C_ICR_PECCF, base + STM32F7_I2C_ICR);
                f7_msg->result = -EINVAL;
        }