i3c: mipi-i3c-hci: Do not unmap region not mapped for transfer
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Thu, 21 Sep 2023 05:57:01 +0000 (08:57 +0300)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 25 Sep 2023 21:35:14 +0000 (23:35 +0200)
Fix following warning (with CONFIG_DMA_API_DEBUG) which happens with a
transfer without a data buffer.

DMA-API: i3c mipi-i3c-hci.0: device driver tries to free DMA memory it has not allocated [device address=0x0000000000000000] [size=0 bytes]

For those transfers the hci_dma_queue_xfer() doesn't create a mapping and
the DMA address pointer xfer->data_dma is not set.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20230921055704.1087277-10-jarkko.nikula@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/i3c/master/mipi-i3c-hci/dma.c

index cb41d0026abd2bb8fb5f0269b2f9fef63e16e286..c8720e6334c9e693e451a1f483690f1097e11671 100644 (file)
@@ -347,6 +347,8 @@ static void hci_dma_unmap_xfer(struct i3c_hci *hci,
 
        for (i = 0; i < n; i++) {
                xfer = xfer_list + i;
+               if (!xfer->data)
+                       continue;
                dma_unmap_single(&hci->master.dev,
                                 xfer->data_dma, xfer->data_len,
                                 xfer->rnw ? DMA_FROM_DEVICE : DMA_TO_DEVICE);