f2fs: fix to remove unnecessary f2fs_bug_on() to avoid panic
authorChao Yu <chao@kernel.org>
Fri, 12 Jan 2024 19:41:31 +0000 (03:41 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 6 Feb 2024 02:58:39 +0000 (18:58 -0800)
verify_blkaddr() will trigger panic once we inject fault into
f2fs_is_valid_blkaddr(), fix to remove this unnecessary f2fs_bug_on().

Fixes: 18792e64c86d ("f2fs: support fault injection for f2fs_is_valid_blkaddr()")
Reviewed-by: Daeho Jeong <daehojeong@google.com>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/f2fs.h

index 69e71460a9502d31bb7962f5232a8c6875078d62..ab710bb6d8b32e5bf5ba2b13d8948c55e7602943 100644 (file)
@@ -3470,11 +3470,9 @@ bool f2fs_is_valid_blkaddr(struct f2fs_sb_info *sbi,
 static inline void verify_blkaddr(struct f2fs_sb_info *sbi,
                                        block_t blkaddr, int type)
 {
-       if (!f2fs_is_valid_blkaddr(sbi, blkaddr, type)) {
+       if (!f2fs_is_valid_blkaddr(sbi, blkaddr, type))
                f2fs_err(sbi, "invalid blkaddr: %u, type: %d, run fsck to fix.",
                         blkaddr, type);
-               f2fs_bug_on(sbi, 1);
-       }
 }
 
 static inline bool __is_valid_data_blkaddr(block_t blkaddr)