svcrdma: Remove queue-shortening warnings
authorChuck Lever <chuck.lever@oracle.com>
Mon, 11 Dec 2023 15:24:28 +0000 (10:24 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 7 Jan 2024 22:54:32 +0000 (17:54 -0500)
These won't have much diagnostic value for site administrators.
Since they can't be disabled, they become noise.

What's more, the subsequent rdma_create_qp() call adjusts the Send
Queue size (possibly downward) without warning, making the size
reported by these pr_warns inaccurate.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/xprtrdma/svc_rdma_transport.c

index 451814eb12b9f2a1726c799423162893d8958f8e..040d2ef6400cc97177ebbf5046e30c8b891f2e0f 100644 (file)
@@ -412,8 +412,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
        rq_depth = newxprt->sc_max_requests + newxprt->sc_max_bc_requests +
                   newxprt->sc_recv_batch;
        if (rq_depth > dev->attrs.max_qp_wr) {
-               pr_warn("svcrdma: reducing receive depth to %d\n",
-                       dev->attrs.max_qp_wr);
                rq_depth = dev->attrs.max_qp_wr;
                newxprt->sc_recv_batch = 1;
                newxprt->sc_max_requests = rq_depth - 2;
@@ -423,11 +421,8 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt)
        ctxts = rdma_rw_mr_factor(dev, newxprt->sc_port_num, RPCSVC_MAXPAGES);
        ctxts *= newxprt->sc_max_requests;
        newxprt->sc_sq_depth = rq_depth + ctxts;
-       if (newxprt->sc_sq_depth > dev->attrs.max_qp_wr) {
-               pr_warn("svcrdma: reducing send depth to %d\n",
-                       dev->attrs.max_qp_wr);
+       if (newxprt->sc_sq_depth > dev->attrs.max_qp_wr)
                newxprt->sc_sq_depth = dev->attrs.max_qp_wr;
-       }
        atomic_set(&newxprt->sc_sq_avail, newxprt->sc_sq_depth);
 
        newxprt->sc_pd = ib_alloc_pd(dev, 0);