ALSA: echoaudio: re-enable IRQs on failure path

This should be spin_unlock_irq() instead of spin_lock().

Fixes: 6c3312544873 ("ALSA: echoaudio: Prevent races in calls to set_audio_format()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200713105324.GB251988@mwanda
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index e81f42811f455cf1a65a1cb45a2e185a8ea782b0..6aeb99aa241459fac47a02b9c8ec65f927be215b 100644 (file)
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -721,7 +721,7 @@ static int pcm_prepare(struct snd_pcm_substream *substream)
        spin_lock_irq(&chip->lock);
 
        if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) {
-               spin_unlock(&chip->lock);
+               spin_unlock_irq(&chip->lock);
                return -EINVAL;
        }