staging: rtl8188eu: remove the "trigger gpio 0" hal variable
authorMartin Kaiser <martin@kaiser.cx>
Sun, 18 Jul 2021 17:36:02 +0000 (19:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Jul 2021 08:31:22 +0000 (10:31 +0200)
The hal variable to trigger gpio 0 seems to be a leftover from debugging
code that was removed. An empty function is called when this variable is
written to.

Remove the empty function and the variable itself. It should be safe to
remove an entry from the hw_variables enum as this enum is used only
within the rtl8188eu driver.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210718173610.894-2-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/usb_halinit.c
drivers/staging/rtl8188eu/include/hal_intf.h

index 3c9a2c99c0d4fd6699dc650685b5cd33084d8f6b..b53d1c21f55641e22850fb002fb5eac9648e9087 100644 (file)
@@ -1002,11 +1002,6 @@ void rtw_hal_read_chip_info(struct adapter *Adapter)
        readAdapterInfo_8188EU(Adapter);
 }
 
-#define GPIO_DEBUG_PORT_NUM 0
-static void rtl8192cu_trigger_gpio_0(struct adapter *adapt)
-{
-}
-
 static void ResumeTxBeacon(struct adapter *adapt)
 {
        struct hal_data_8188e *haldata = adapt->HalData;
@@ -1550,9 +1545,6 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)
                        }
                }
                break;
-       case HW_VAR_TRIGGER_GPIO_0:
-               rtl8192cu_trigger_gpio_0(Adapter);
-               break;
        case HW_VAR_RPT_TIMER_SETTING:
                {
                        u16 min_rpt_time = (*(u16 *)val);
index 2e3e933781eb8ead0265efb54f489d15d4c3ef52..2eb4f1fa75bbfd93310f0d2cad6c7b9433978794 100644 (file)
@@ -74,7 +74,6 @@ enum hw_variables {
        HW_VAR_TDLS_RS_RCR,
        HW_VAR_TDLS_DONE_CH_SEN,
        HW_VAR_INITIAL_GAIN,
-       HW_VAR_TRIGGER_GPIO_0,
        HW_VAR_BT_SET_COEXIST,
        HW_VAR_BT_ISSUE_DELBA,
        HW_VAR_CURRENT_ANTENNA,