x86/microcode: Clean up mc_cpu_down_prep()
authorThomas Gleixner <tglx@linutronix.de>
Mon, 2 Oct 2023 11:59:55 +0000 (13:59 +0200)
committerBorislav Petkov (AMD) <bp@alien8.de>
Tue, 24 Oct 2023 13:05:54 +0000 (15:05 +0200)
This function has nothing to do with suspend. It's a hotplug
callback. Remove the bogus comment.

Drop the pointless debug printk. The hotplug core provides tracepoints
which track the invocation of those callbacks.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20231002115903.028651784@linutronix.de
arch/x86/kernel/cpu/microcode/core.c

index 0ed96d273feea97a1aab167fa48c425538936078..e306feeb374f894f27c6a56e019200f1a24f3dfe 100644 (file)
@@ -498,16 +498,10 @@ static int mc_cpu_online(unsigned int cpu)
 
 static int mc_cpu_down_prep(unsigned int cpu)
 {
-       struct device *dev;
-
-       dev = get_cpu_device(cpu);
+       struct device *dev = get_cpu_device(cpu);
 
        microcode_fini_cpu(cpu);
-
-       /* Suspend is in progress, only remove the interface */
        sysfs_remove_group(&dev->kobj, &mc_attr_group);
-       pr_debug("%s: CPU%d\n", __func__, cpu);
-
        return 0;
 }