wcn36xx: Return result of set_power_params in suspend
authorBryan O'Donoghue <bryan.odonoghue@linaro.org>
Sat, 5 Jun 2021 01:11:29 +0000 (02:11 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 14 Jun 2021 15:18:09 +0000 (18:18 +0300)
wcn36xx_smd_set_power_params() can return an error. For the purposes of
entering into suspend we need the suspend() function to trap and report
errors up the stack.

First step in this process is reporting the existing result code for
wcn36xx_smd_set_power_params().

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Tested-by: Benjamin Li <benl@squareup.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210605011140.2004643-2-bryan.odonoghue@linaro.org
drivers/net/wireless/ath/wcn36xx/main.c

index afb4877eaad8f6c5e25c2b3e86e2ba981ddd269b..b361e40697a627cbb815ab9d83e30ddeb4ed3f11 100644 (file)
@@ -1091,12 +1091,14 @@ static int wcn36xx_sta_remove(struct ieee80211_hw *hw,
 static int wcn36xx_suspend(struct ieee80211_hw *hw, struct cfg80211_wowlan *wow)
 {
        struct wcn36xx *wcn = hw->priv;
+       int ret;
 
        wcn36xx_dbg(WCN36XX_DBG_MAC, "mac suspend\n");
 
        flush_workqueue(wcn->hal_ind_wq);
-       wcn36xx_smd_set_power_params(wcn, true);
-       return 0;
+       ret = wcn36xx_smd_set_power_params(wcn, true);
+
+       return ret;
 }
 
 static int wcn36xx_resume(struct ieee80211_hw *hw)